Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dedicated hosts #592

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

thheinen
Copy link
Contributor

Description

This implements allocation/deallocation of dedicated hosts.

It also introduces new config options allocate_dedicated_host and deallocate_dedicated_host, which are set to false by default to avoid accidental cost impacts. Also, mac instances will not allow deallocation before 24 hours have passed, so they will (when #591 is implemented) fail if the driver tries automatically deallocating.

Issues Resolved

#590

Type of Change

New Feature

Check List

  • All tests pass

Signed-off-by: Thomas Heinen <theinen@tecracer.de>
@thheinen thheinen requested a review from a team November 25, 2022 17:12
@thheinen
Copy link
Contributor Author

thheinen commented Nov 25, 2022

After documentation got pulled out of the kitchen repositories, can anybody give me a hint on where to add those settings?

Also: those failed unit tests are not related to my code. And two of those look... weird ;-)

Signed-off-by: Thomas Heinen <theinen@tecracer.de>
@ashiqueps
Copy link
Contributor

Hey @tecracer-theinen,

The documentation was moved to the test-kitchen repo. You can update that at https://github.com/test-kitchen/test-kitchen/blob/main/docs/content/docs/drivers/aws.md and create a separate PR for documentation.

@xorima
Copy link
Member

xorima commented Nov 28, 2022

@ashiqueps can we get the contributing guidelines updated to help people discover this docs location?

@ashiqueps
Copy link
Contributor

@xorima

Sure, I'll update the guidelines.

@xorima xorima merged commit ac47546 into test-kitchen:main Nov 30, 2022
@ashiqueps ashiqueps mentioned this pull request Dec 1, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants