Newest vagrant no long requires vagrant-winrm plugin #379
Conversation
lib/kitchen/driver/vagrant.rb
Outdated
| @@ -556,7 +556,7 @@ def verify_winrm_plugin | |||
| " Please upgrade to version 1.6 or higher from #{WEBSITE}." | |||
| end | |||
|
|
|||
| if !winrm_plugin_installed? | |||
| if Gem::Version.new(vagrant_version) < Gem::Version.new("2.1.5") && !winrm_plugin_installed? | |||
There was a problem hiding this comment.
<= Gem::Version("2.1.5") or < Gem::Version("2.1.6")
There was a problem hiding this comment.
Thanks @chrisroberts ! I meant to message yesterday - I was testing this locally from TK and you obviously already saw this PR 😄. But it was working well for me!
There was a problem hiding this comment.
@chrisroberts Do you have an ETA for 2.1.6 yet?
There was a problem hiding this comment.
@tyler-ball Next release will be 2.2.0 and we are shooting to have it wrapped up and ready to go tomorrow. If things aren't fully ready for tomorrow then it will be Tuesday next week.
There was a problem hiding this comment.
Need to fix this check to be < 2.2.0
|
Hey guys, looks like hashicorp/vagrant#10263 got merged. Does this mean this can be as well? (Sorry, I'd like to get my test-kitchen/vagrant/chef nodes up to date, and this is one of the current annoyances) |
|
The check itself needs to be fixed a bit but once that is done then it can be merged and released. |
tyler-ball
force-pushed
the
vagrant_winrm_unecessary
branch
2 times, most recently
from
416b694
to
100edd4
Compare
Signed-off-by: tyler-ball <tball@chef.io>
tyler-ball
force-pushed
the
vagrant_winrm_unecessary
branch
from
100edd4
to
9153d87
Compare
This is pending on Add winrm and upload commands hashicorp/vagrant#10263 getting merged and released2.1.5and2.1.7. Between those versions vagrant does not requirevagrant-winrmbut it will not work because the code from Add winrm and upload commands hashicorp/vagrant#10263 is not in thereSigned-off-by: tyler-ball tball@chef.io