Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_feat_: add arm64 to bento box name #483

Merged
merged 2 commits into from
Feb 7, 2023
Merged

_feat_: add arm64 to bento box name #483

merged 2 commits into from
Feb 7, 2023

Conversation

Stromweld
Copy link
Contributor

Description

adds -arm64 to bento box name automatically if on an arm64 cpu host

Issues Resolved

List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant

Type of Change

Our release process assumes you are using Conventional Commit messages.

The most important prefixes you should have in mind are:

  • _fix_: which represents bug fixes, and correlates to a SemVer patch.
  • _feat_: which represents a new feature, and correlates to a SemVer minor.
  • _feat!_:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.

If you have not included a conventional commit message this can be fixed on merge.

Check List

adds `-arm64` to bento box name automatically if on an arm64 cpu host

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
Copy link
Contributor Author

@tas50 Thanks for the review. I don't have write access to this repo so will also need someone to merge and potentially release this as well.

@xorima xorima merged commit 620f5f1 into test-kitchen:main Feb 7, 2023
@Stromweld Stromweld deleted the patch-1 branch February 7, 2023 14:39
@ashiqueps ashiqueps mentioned this pull request Feb 9, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants