Retry Kitchen::Provisioner#run_command after allowed exit codes

[smurawski]

• Allow user to define exit codes to retry Provision#run_command
• Allow user to define wait time between attempts
• Allow user to define exit codes to retry
• Allow user to define maximum number of retry attempts

Resolves #1016

[smurawski]

I've tested this against Windows, Centos, and Ubuntu guests. The Windows guests worked the most consistently. The Centos and Ubuntu guests were more of a race to see if Chef could finish before the system shut down. (See chef/chef#5026)

[smurawski]

With this PR - all provisioners support three new configuration settings.

• retry_on_exit_code - which takes an array of exit codes that can indicate that kitchen should retry the converge command. Defaults to an empty array.
• max_retries - number of times to retry the converge before passing along the failed status. Defaults to 1.
• wait_for_retry - number of seconds to wait between converge attempts. Defaults to 30.

[smurawski]

Appveyor build failure seems specific to the build box. More "symlink is unimplemented" errors, which seem to be common amongst appveyor builds recently.

Rebased on master after merging #1057 to fix appveyor tests.

[cheeseplus]

+1

[adamleff]

Is this debug output? If not, we should probably use the logger methods instead.

[mwrock]

I had the same question and then noticed puts getting used for these in several places in TK. a bit weird but separate from this PR

[smurawski]

Oops.. that should be pulled. I was troubleshooting the difference between actionfailed and instancefailed. Thanks.

[adamleff]

Some minor things, all non-blockers. 👍

[mwrock]

👍

[lamont-granquist]

👍

[carpnick]

Thanks for doing this @smurawski. This one was a long time coming to TK. Thanks for putting in the effort on chef and TK to get this done.