Adds pre_create_command for running arbitrary commands #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderanger
suggested changes
Oct 6, 2017
sean797
force-pushed
the
pre_create_command
branch
2 times, most recently
from
9db113c
to
4e8fd2d
Compare
|
Thanks for taking a look @coderanger. Updated, rebased and add some tests since tests are now passing 👍 |
coderanger
suggested changes
Oct 6, 2017
spec/kitchen/driver/base_spec.rb
Outdated
| @@ -88,6 +88,18 @@ class Slow < Base | |||
| end | |||
| end | |||
|
|
|||
| describe ".pre_create_command" do | |||
| it "run command" do | |||
| config[:pre_create_command] = "echo works 2&>1 > /dev/null" | |||
There was a problem hiding this comment.
This will fail on Windows. You can use driver.expects(:run_command).with("echo works 2&>1 > /dev/null") to avoid actually running anything. Similarly with the fail test, that one is more technically okay but just for unit test speed it would be nice to use Mocha to stub it raising the exception rather than actually running a failed command :)
sean797
force-pushed
the
pre_create_command
branch
from
4e8fd2d
to
a256c68
Compare
This allows .kitchen.yml to contains the following: ```yaml driver: pre_create_command: echo 'this runs before a instance is created' ```
sean797
force-pushed
the
pre_create_command
branch
from
a256c68
to
d8b2e8e
Compare
|
Ugh Windows... Anyway updated and test are 🍏 |
coderanger
approved these changes
Oct 6, 2017
There was a problem hiding this comment.
LGTM, will leave this open for a bit in case @cheeseplus wants to review too and he is music-ing for a few days. Thanks for the patch!
cheeseplus
approved these changes
Oct 23, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows .kitchen.yml to contains the following:
Adding this to core since the discussion at test-kitchen/kitchen-docker#249 kitchen-vagrant already has this functionally, but this adds it to all drivers.