Backport additional Chef license fixes to 1-stable #1557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on chef/license-acceptance#43 Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Before this change if the license acceptance failed and raised an exception the 'cleanup_sandbox' was called in an ensure. But the sandbox would not have been created yet so it would fail with an error like: Failed to complete #converge action: [Sandbox directory has not yet been created. Please run Kitchen::Provisioner::ChefGithub#create_sandox before trying to access the path.] Signed-off-by: tyler-ball <tball@chef.io>
…en released Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
DK or Workstation not just DK Properly capitalize Policyfile Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so we can ship a TK 1.x that supports the latest Chef Infra Client.