run specs on 3.1 #1867
Merged
run specs on 3.1 #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kasif <kadnan@progress.com>
Signed-off-by: kasif <kadnan@progress.com>
damacus
reviewed
Feb 24, 2022
spec/kitchen/util_spec.rb
Outdated
| # ].map { |f| File.join(@root, f) } | ||
| # (listed - expected).must_equal [] | ||
| # (expected - listed).must_equal [] | ||
| # end |
There was a problem hiding this comment.
I think we need to optionally include "bar/." if the Ruby version is below 3.1. I can't see anything in the Ruby 3.1 release notes. But I've confirmed locally that between 3.0 and 3.1 Dir.glob no longer returns the trailing . directories. i.e. this is no longer returned in 3.1
"./.vagrant/bundler/."There was a problem hiding this comment.
Right. I found the bug in the tracker here https://bugs.ruby-lang.org/issues/18436
So it looks like the trailing . was in fact a bug
There was a problem hiding this comment.
@damacus , wondering what would be the best way to handle the spec in this case for ruby 3.0 and lower. For now, i have added a check for version >=3.1
Signed-off-by: kasif <kadnan@progress.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kasif kadnan@progress.com
Description
Describe what this change achieves
Issues Resolved
List any existing issues this PR resolves
Check List