New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rescue Errno::ETIMEDOUT instead of Timeout::Error on Establish #802
Rescue Errno::ETIMEDOUT instead of Timeout::Error on Establish #802
Conversation
net-ssh 2.10 does not use 'timeout' anymore. See: net-ssh/net-ssh@58b3797
90224d2
to
8532ada
Compare
@Annih will you rebase this off master? Should fix the appveyor issue |
…meout Rescue Errno::ETIMEDOUT instead of Timeout::Error on Establish
Hey @Annih I took care of the merge. I changed the code to catch both errors and retry them so it works with net-ssh 2.9 and 2.10 Also, thanks for this PR and getting the ball rolling on these fixes! |
Sorry for the delay @tyler-ball and thanks for the quick release! |
@tyler-ball I think the problem is still there, at least when using net-ssh 2.10, because Timeout::Error is still referenced in the code but not in net-ssh anymore :
Tested with ruby 2.1.2, Kitchen 1.4.2, net-ssh 2.10.0beta2 |
@komuta Thanks for the report! What does your environment look like? Are you using the ChefDK? Can you modify |
I was just beginning to try Test Kitchen with Vagrant, Ansible and Serverspec. I don't use Chef at all. I did the modification and now it works perfectly well. I'll submit a new pull request. |
@tyler-ball Here is the PR : #866 |
Fix #800
net-ssh 2.10 does not use 'timeout' anymore, it use the Socket
connect_timeout
instead.See: net-ssh/net-ssh@58b3797 and net-ssh/net-ssh@9bfbdc9