Support Empty Proxy Settings #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ftp_proxy do not export environment values for those keys. Provides a mechanism to prevent local proxy environment settings from being pushed to the test node Fixes test-kitchen#934
|
👍 - I bumped the build so the failure it's showing is totally fine (it's the EC2 one that always fails for non-repo PRs. |
|
Anything I need to do to get this merged in? |
|
👍 |
|
Thanks!! |
|
Ugh it's not letting me merge from my phone. Will merge later. |
|
👍 I'll merge. |
|
Just needed some more +1s - thanks folks! |
|
Awesome. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When empty config values are provided for http_proxy, https_proxy or ftp_proxy do not export local environment values for those keys to the test system.
Fixes #934