Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hadolint, a Dockerfile linter #936

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Add Hadolint, a Dockerfile linter #936

merged 2 commits into from
Mar 23, 2023

Conversation

rdavid
Copy link
Member

@rdavid rdavid commented Mar 19, 2023

@rdavid rdavid self-assigned this Mar 19, 2023
@sebrandon1
Copy link
Member

/dci-rerun

sebrandon1
sebrandon1 reviewed Mar 20, 2023
View reviewed changes
.github/workflows/pre-main.yaml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@ramperher
Copy link
Collaborator

/dci-rerun

@rdavid
Copy link
Member Author

rdavid commented Mar 21, 2023

Added dependabot configuration to follow up for image version. Need something similar to follow package versions.

sebrandon1
sebrandon1 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We can manually update the package dependencies until we come up with something automatic.

@rdavid rdavid requested a review from edcdavid March 22, 2023 12:28
@rdavid
Copy link
Member Author

rdavid commented Mar 22, 2023

/dci-rerun

1 similar comment
@ramperher
Copy link
Collaborator

/dci-rerun

This was referenced Mar 22, 2023
Merged
Merged
ramperher
ramperher approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@ramperher ramperher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdavid , feel free to merge this if needed, DCI failure is not related to your change, it's related to #937.

@rdavid rdavid merged commit ae816b2 into test-network-function:main Mar 23, 2023
@rdavid rdavid deleted the lint-dockerfile branch March 23, 2023 15:41
@sebrandon1 sebrandon1 mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebrandon1 sebrandon1 sebrandon1 approved these changes

@ramperher ramperher ramperher approved these changes

@greyerof greyerof Awaiting requested review from greyerof

@edcdavid edcdavid Awaiting requested review from edcdavid

Assignees

@rdavid rdavid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdavid @sebrandon1 @ramperher