fix: make minitest sampling work

Co-Authored-By: @ericenns
test-prof · May 8, 2024 · d07ba0e · d07ba0e
1 parent cdf4b82
commit d07ba0e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/test_prof/recipes/minitest/sample.rb b/lib/test_prof/recipes/minitest/sample.rb
@@ -7,14 +7,16 @@ module MinitestSample
     CORE_RUNNABLES = [
       Minitest::Test,
       defined?(Minitest::Unit::TestCase) ? Minitest::Unit::TestCase : nil,
-      Minitest::Spec
+      defined?(Minitest::Spec) ? Minitest::Spec : nil,
     ].compact.freeze
 
     class << self
       def suites
         # Make sure that sample contains only _real_ suites
         Minitest::Runnable.runnables
-          .reject { |suite| CORE_RUNNABLES.include?(suite) }
+          .select do |suite|
+            CORE_RUNNABLES.any? { |kl| suite < kl } && suite.runnable_methods.any?
+          end
       end
 
       def sample_groups(sample_size)

diff --git a/spec/integrations/fixtures/minitest/sample_fixture.rb b/spec/integrations/fixtures/minitest/sample_fixture.rb
@@ -14,7 +14,10 @@ def test_pass2
   end
 end
 
-class AnotherSomethingTest < Minitest::Test
+class CustomTestCase < Minitest::Test
+end
+
+class AnotherSomethingTest < CustomTestCase
   def test_pass
     assert true
   end