Skip to content

/ test-prof

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve specs sampling #103

Merged
merged 6 commits into from Oct 22, 2018
Merged

Improve specs sampling #103

merged 6 commits into from Oct 22, 2018

Conversation

@mkldon
Copy link
Contributor

@mkldon mkldon commented Oct 19, 2018

Closes #101
@palkan palkan self-requested a review Oct 19, 2018
@palkan
palkan approved these changes Oct 19, 2018
View changes
Copy link
Collaborator

@palkan palkan left a comment

Awesome work!

Let's rebase it to resolve a conflict and we're done.
mkldon added 6 commits Oct 15, 2018
@mkldon
Improve sampling for RSpec
3dc6d4f
@mkldon
Improve sampling for minitest
f673e78
@mkldon
Fix sampling docs
e50b0a2
@mkldon
Rename GROUP_SAMPLE var to SAMPLE_GROUPS
627d2f6
@mkldon
Update changelog
dce1b3f
@mkldon
Add github link to CHANGELOG.md
f4cf5d3
@mkldon mkldon force-pushed the mkldon:sample branch from c3f2401 to f4cf5d3 Oct 22, 2018
@mkldon
Copy link
Contributor Author

@mkldon mkldon commented Oct 22, 2018

Done @palkan
@palkan palkan merged commit fec3b55 into test-prof:master Oct 22, 2018
@palkan
Copy link
Collaborator

@palkan palkan commented Oct 22, 2018

Thanks!
dmagro added a commit to dmagro/test-prof that referenced this pull request Nov 7, 2018
@mkldon @dmagro
Improve specs sampling (test-prof#103)
6cf4ccb 
Closes test-prof#101
@palkan
Copy link
Collaborator

@palkan palkan commented Aug 2, 2019

Hey @mkldon!

Could you please send me your actual email address to palkan@evl.ms? We're collecting CultOfMartians participants contact info (to ping you later and ask where we can send some merch for you 🙂)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palkan palkan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Improve specs sampling
2 participants
@mkldon @palkan