Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve specs sampling #103

Merged
merged 6 commits into from Oct 22, 2018
Merged

Improve specs sampling #103

merged 6 commits into from Oct 22, 2018

Conversation

mkldon
Copy link
Contributor

@mkldon mkldon commented Oct 19, 2018

Closes #101

@palkan palkan self-requested a review October 19, 2018 17:27
palkan
palkan approved these changes Oct 19, 2018
View reviewed changes
Copy link
Collaborator

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Let's rebase it to resolve a conflict and we're done.

@mkldon
Copy link
Contributor Author

mkldon commented Oct 22, 2018

Done @palkan

@palkan palkan merged commit fec3b55 into test-prof:master Oct 22, 2018
@palkan
Copy link
Collaborator

palkan commented Oct 22, 2018

Thanks!

dmagro pushed a commit to dmagro/test-prof that referenced this pull request Nov 7, 2018
@mkldon @dmagro
Improve specs sampling (test-prof#103)
6cf4ccb 
Closes test-prof#101
@palkan
Copy link
Collaborator

palkan commented Aug 2, 2019

Hey @mkldon!

Could you please send me your actual email address to palkan@evl.ms? We're collecting CultOfMartians participants contact info (to ping you later and ask where we can send some merch for you 🙂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palkan palkan palkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve specs sampling
2 participants
@mkldon @palkan