Add FactoryBot.get_factory_default #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
requested changes
Mar 22, 2023
| @@ -168,6 +168,10 @@ def set_factory_default(name, obj, preserve_traits: FactoryDefault.config.preser | |||
| ) | |||
| end | |||
|
|
|||
| def get_factory_default(name, *args) | |||
There was a problem hiding this comment.
Let's call it #fetch_factory_default
| @@ -168,6 +168,10 @@ def set_factory_default(name, obj, preserve_traits: FactoryDefault.config.preser | |||
| ) | |||
| end | |||
|
|
|||
| def get_factory_default(name, *args) | |||
| FactoryDefault.get(name, args, args.extract_options!, false) | |||
There was a problem hiding this comment.
Why can't we use *args, **kwargs instead of #extract_options!? No need to support legacy Hash-to-kwarg conversion, it's a new API method.
| @@ -236,7 +240,7 @@ def register(name, obj, **options) | |||
| obj | |||
| end | |||
|
|
|||
| def get(name, traits = nil, overrides = nil) | |||
| def get(name, traits = nil, overrides = nil, write_stats = true) | |||
There was a problem hiding this comment.
Let's rename to skip_stats and turn this option into a keyword argument.
palkan
force-pushed
the
master
branch
3 times, most recently
from
f6d4418
to
3dfe1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
FactoryBot.get_factory_defaultmethod that allows users to retrieve the default for a given setup. Useful in cases where the factory default is desired but the record isn't directly created through factory bot (such as an after build hook)