add threshold config parameter for FactoryProf #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
requested changes
May 21, 2024
| expect(output).to include("FactoryProf enabled (simple mode)") | ||
|
|
||
| expect(output).to include("Factories usage") | ||
| expect(output).to match(/Total: 16\n\s+Total top-level: 8\n\s+Total time: \d{2}+:\d{2}\.\d{3} \(out of \d{2}+:\d{2}\.\d{3}\)\n\s+Total uniq factories: 1/) |
There was a problem hiding this comment.
We should only hide less used factories from the output but totals still must show the actual data, i.e., here we should see "Total uniq factories: 2".
Thus, we need to update the exclusion logic (no select!, just skip when printing) and update the test to check that there is not match for skipped factories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add threshold config parameter for
FactoryProfto ignore factories which total number of calls is less than the provided thresholdIs there anything you'd like reviewers to focus on?
I'm not sure if support for this option is needed for flamegraph mode? As of now, I have only added support for simple mode
Checklist
Closes #290