fix: noIdenticalTitles efficiency & speed

testcafe-community · Oct 23, 2021 · 2e2b06a · 2e2b06a
1 parent dfe28cc
commit 2e2b06a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 16 deletions.
diff --git a/lib/rules/no-identical-title.ts b/lib/rules/no-identical-title.ts
@@ -69,12 +69,14 @@ export default createRule({
     create(context) {
         let isInsideTest = false;
         let hasRecordedTestName = false;
+        let currentTestNode: CallExpression | null = null;
 
         const testTitles: { [key: string]: [CallExpressionArgument] } = {};
 
         const resetFlags = () => {
             hasRecordedTestName = false;
             isInsideTest = false;
+            currentTestNode = null;
         };
 
         const addTestTitle = (testTitle: string, node: CallExpression) => {
@@ -93,6 +95,7 @@ export default createRule({
                 return;
             }
             isInsideTest = true;
+            currentTestNode = node;
             addTestTitle(testTitle, node);
             hasRecordedTestName = true;
         };
@@ -117,19 +120,7 @@ export default createRule({
         };
 
         const unknownFnCallEXIT = (node: CallExpression) => {
-            if (!isInsideTest) return; // Short circuit
-
-            let fnName;
-            let objectName;
-            try {
-                [fnName, objectName] = determineCodeLocation(node);
-            } catch (e) {
-                // ABORT: Failed to evaluate rule effectively
-                // since I cannot derive values to determine location in the code
-                return;
-            }
-            if (objectName !== "test") return;
-            if (fnName === "test" || testFnAttributes.includes(fnName)) {
+            if (isInsideTest && node === currentTestNode) {
                 resetFlags();
             }
         };
@@ -166,9 +157,8 @@ export default createRule({
             ) => {
                 extractTestTitle(node);
             },
-            [`${testFnCallExpression}[callee.name=test]:exit`]: () => {
-                resetFlags();
-            },
+            [`${testFnCallExpression}[callee.name=test]:exit`]:
+                unknownFnCallEXIT,
             [`${testFnCallExpression}[callee.type=CallExpression]`]:
                 unknownFnCallENTER,
             [`${testFnCallExpression}[callee.type=CallExpression]:exit`]:

diff --git a/tests/lib/rules/no-identical-title.test.ts b/tests/lib/rules/no-identical-title.test.ts
@@ -84,6 +84,10 @@ describe("ESLint Code Snippets", () => {
                 await t.click().expect(true).ok();
             });
             `,
+            // Futuristic TestCafe || unexpected test chain => ignore as valid
+            `test.futureModifier("test", async t => {
+                await t.expect(true).ok();
+            });`,
             // ignore undeterminable code (don't throw an error, not this rule's focus)
             `test(/^regex_name/, async t => {});`,
             `test(null, async t => {})`,