Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volumes are not deleted on docker 24.0.1 #79

Closed
reda-alaoui opened this issue May 30, 2023 · 2 comments
Closed

volumes are not deleted on docker 24.0.1 #79

reda-alaoui opened this issue May 30, 2023 · 2 comments

Comments

@reda-alaoui
Copy link

Context

Seems related to docker/cli#4028

How to reproduce with the CLI

  1. Create a volume
    $ docker volume create foo --label foo=bar
  2. Try to prune it with a simple filter:
    $ docker volume prune --filter "label=foo=bar"
    WARNING! This will remove anonymous local volumes not used by at least one container.
    Are you sure you want to continue? [y/N] y
    Total reclaimed space: 0B
    $ docker volume ls --filter "label=foo=bar"
    DRIVER    VOLUME NAME
    local     foo

The volume is still there, not removed.

Workaround with the CLI

$ docker volume prune --filter "label=foo=bar" --filter "all=1"
WARNING! This will remove anonymous local volumes not used by at least one container.
Are you sure you want to continue? [y/N] y
Deleted Volumes:
foo

Total reclaimed space: 0B
$ docker volume ls --filter "label=foo=bar"
DRIVER    VOLUME NAME

What has this to do with Ryuk ?

Ryuk has the same behaviour as the Docker CLI. It emits a command without all=1 that has no effect on the volumes.

@HofmeisterAn
Copy link
Contributor

HofmeisterAn commented May 30, 2023

This issue should be fixed with #77 (testcontainers/ryuk:0.5.1).

@reda-alaoui
Copy link
Author

Tested on 0.5.1 with success 👍

@reda-alaoui reda-alaoui closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants