fix: Add filter all=true to volume prune #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
reviewed
May 16, 2023
mdelapenya
reviewed
May 16, 2023
|
@HofmeisterAn do you think we should produce a |
Yes, then we can include it in the upcoming .NET release. |
|
Sweet! Let's include also #71 in the new release |
eddumelendez
pushed a commit
to eddumelendez/moby-ryuk
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The pull request checks Docker's API version. If the version is equal or greater than
1.42, it addsall=trueto the volume prune filter.Why is it important?
The latest Moby release (v23.0.0), introduces a breaking API change. It is not backwards compatible. I checked an older version (Docker Desktop for Mac 4.14.1). The mentioned API version requires another filter (
all=true) to prune all volumes. Without the additional filter, only anonymous volumes (those without names) are removed.Do you have any better idea in mind to check the API version?
Related issues