-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the manifest check #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Mmmm failing again: https://github.com/testcontainers/moby-ryuk/actions/runs/9222172622/job/25373416643 @gesellix could you please take a look? |
Yes, will do! |
Oops - my bad: I only fixed the publish workflow, but not the build workflow. I'll create another pull request to fix the build workflow, too. Sorry. |
(cherry picked from commit 36c1681)
I'll certainly extract a shared action so that the workflows become easier to maintain. This one and #131 are the best examples to have better abstractions and keeping code DRY 😅 |
thank you @gesellix! Now the incremental docker images are live https://hub.docker.com/r/testcontainers/ryuk/tags, so we can test them before any release. Thank you for your hard work! |
That's great! Thanks! 🎉 |
This is a follow-up to #120