Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the manifest check #130

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix the manifest check #130

merged 1 commit into from
May 24, 2024

Conversation

gesellix
Copy link
Contributor

This is a follow-up to #120

  • The manifest now contains entries with "unknown" architecture. The entries aren't relevant to our check on existence of expected "linux" and "windows" entries, so we're simply ignoring "unknown" architectures.
  • The diff has been fixed to use our input from stdin instead of trying to read any files.

Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this May 24, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label May 24, 2024
@mdelapenya mdelapenya merged commit 36c1681 into testcontainers:main May 24, 2024
9 checks passed
@mdelapenya
Copy link
Contributor

Mmmm failing again: https://github.com/testcontainers/moby-ryuk/actions/runs/9222172622/job/25373416643

@gesellix could you please take a look?

@gesellix
Copy link
Contributor Author

Yes, will do!

@gesellix
Copy link
Contributor Author

Oops - my bad: I only fixed the publish workflow, but not the build workflow. I'll create another pull request to fix the build workflow, too. Sorry.

gesellix added a commit to gesellix/moby-ryuk that referenced this pull request May 24, 2024
@gesellix
Copy link
Contributor Author

I'll certainly extract a shared action so that the workflows become easier to maintain. This one and #131 are the best examples to have better abstractions and keeping code DRY 😅

@mdelapenya
Copy link
Contributor

thank you @gesellix! Now the incremental docker images are live https://hub.docker.com/r/testcontainers/ryuk/tags, so we can test them before any release.

Thank you for your hard work!

image

@gesellix
Copy link
Contributor Author

That's great! Thanks! 🎉
I"ll continue with the other repositories, stay tuned :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants