Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also target .NET Standard 2.0 to support .NET Framework #381

Closed
chrisbbe opened this issue May 7, 2021 · 3 comments
Closed

Also target .NET Standard 2.0 to support .NET Framework #381

chrisbbe opened this issue May 7, 2021 · 3 comments
Labels
enhancement New feature or request
Milestone
1.5.0

Comments

@chrisbbe
Copy link
Contributor

chrisbbe commented May 7, 2021

Is your feature request related to a problem? Please describe.
Not targeting .NET Standard 2.0 to make the package usable by .NET Framework.

Describe the solution you'd like
In addition to targeting .NET Standard 2.1, also target .NET Standard 2.0
@HofmeisterAn
Copy link
Collaborator

👍 Shouldn't be much work. We just need to remove some syntactic sugar. I can take a look at it this week.

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label May 10, 2021
@HofmeisterAn HofmeisterAn added this to the 1.5.0 milestone May 10, 2021
@chrisbbe
Copy link
Contributor Author

I have already looked into it, I can provide a PR if you want?

chrisbbe added a commit to chrisbbe/dotnet-testcontainers that referenced this issue May 10, 2021
@chrisbbe
testcontainers#381 #CHANGE Dotnet.Testcontainers
27b7304 
{Changes to target netstandard 2.0}
HofmeisterAn pushed a commit that referenced this issue May 10, 2021
@chrisbbe @HofmeisterAn
[#381] #CHANGE 'assemblyName: DotNet.Testcontainers; function: DotNet…
e4ba13f 
….Testcontainers.csproj'

{Add .NET-Standard 2.0 target.}
@HofmeisterAn
Copy link
Collaborator

HofmeisterAn commented May 10, 2021 •
edited
Loading

#382.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@chrisbbe @HofmeisterAn