Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Start Ryuk as a privileged container #694

Closed
taspeotis opened this issue Nov 28, 2022 · 3 comments · Fixed by #710
Closed

[Enhancement]: Start Ryuk as a privileged container #694

taspeotis opened this issue Nov 28, 2022 · 3 comments · Fixed by #710
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@taspeotis
Copy link

Problem

I'm using podman in lieu of docker. It seems to work fine with TestcontainersSettings.ResourceReaperEnabled = false; however this is not ideal. Without that setting it fails with permission errors.

I have podman running as rootful, I believe if testcontainers-dotnet had a similar option to ryuk.container.privileged = true (to create it with --privileged) it would work completely.

https://www.testcontainers.org/features/configuration/#customizing-ryuk-resource-reaper

containers/podman#14238 (reply in thread)

Solution

Some way to create Ryuk as privileged, for podman and whatever other reasons the testcontainers "Customizing Ryuk resource reaper" documentation refers to:

In some environments ryuk must be started in privileged mode to work properly

Benefit

Works with podman

Alternatives

TestcontainersSettings.ResourceReaperEnabled = false;

Would you like to help contributing this enhancement?

Yes

@taspeotis taspeotis added the enhancement New feature or request label Nov 28, 2022
@HofmeisterAn
Copy link
Collaborator

Indeed, ryuk.container.privileged is not yet supported. We need to add the custom configuration property first, similar to 45a8935. Afterwards with can update the ResourceReaper builder configuration. I suggest two separate PRs. Would you like to add the property first?

@taspeotis
Copy link
Author

Thanks, I'll see what I can do in the next few days.

@taspeotis
Copy link
Author

Sorry I wasn't able to contribute this but thank you for adding it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants