Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PubSub module #1005

Merged
merged 6 commits into from
Oct 15, 2023
Merged

feat: Add PubSub module #1005

merged 6 commits into from
Oct 15, 2023

Conversation

dejandjenic
Copy link
Contributor

This PR add support for GCP PubSub service. I added test for testing this functionality

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 1015770
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/652bb664caba3600081c16e4
😎 Deploy Preview https://deploy-preview-1005--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I have a couple of minor requests to ensure consistency with all the other modules.

src/Testcontainers.PubSub/PubSubBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.PubSub/PubSubBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.PubSub/PubSubBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.PubSub/PubSubContainer.cs Outdated Show resolved Hide resolved
@dejandjenic
Copy link
Contributor Author

@HofmeisterAn can you pls review this again

@dejandjenic
Copy link
Contributor Author

done

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Oct 15, 2023
@HofmeisterAn HofmeisterAn changed the title implement GCP PubSub support feat: Add PubSub module Oct 15, 2023
@HofmeisterAn HofmeisterAn merged commit db16f85 into testcontainers:develop Oct 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants