feat: Add Papercut module #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
requested changes
Nov 11, 2023
Moved client models to test project as this uses them but it not used in package project now Added constants for Port numbers Moved using statements to Usings.cs file Added delegate for getting public SMTP port number
…nto TechLiam-develop
|
@HofmeisterAn is there anything else or is this PR good to merge now? |
I've made some improvements. WDYT? If you're good with it, we are ready to merge. |
TechLiam
commented
Nov 15, 2023
HofmeisterAn
previously approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Testcontainers.Papercut
Why is it important?
Papercut is a testing SMTP server that also has a nice, easy REST API to get the messages in the inbox.
When doing integration testing it is helpful to be able to send emails and have the ability to check their contents by having this container developers will be able to quickly spin up an SMTP server and check the messages delivered to it without having to send emails to a proper SMTP server and email address.
How to test this PR
Unit/Integration tests have been added to the solution that checks the container starts and can have emails sent to it. It also checks the helper methods for getting the emails delivered back out of Papercut from the REST API.