Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update .NET SDK to version 8 (LTS) #1054

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

Updates the .NET SDK to version 8 (latest LTS).

Why is it important?

We are trying to run our tests utilizing the latest .NET SDK (LTS). Testcontainers itself, including the modules, still targets netstandard2.0 and netstandard2.1 to provide support for most .NET Framework and .NET versions.

Related issues

-

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Nov 22, 2023
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit d9fdaf9
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/655e42dbacd0d30008902e96
😎 Deploy Preview https://deploy-preview-1054--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn merged commit a93dcb7 into develop Nov 22, 2023
12 checks passed
@HofmeisterAn HofmeisterAn deleted the feature/use-dotnet-sdk-8 branch November 22, 2023 18:21
@0xced
Copy link
Contributor

0xced commented Nov 27, 2023

Note that SourceLink is now included in the .NET SDK:

Source Link is now included in the .NET SDK. The goal is that by bundling Source Link into the SDK, instead of requiring a separate <PackageReference> for the package, more packages will include this information by default. That information will improve the IDE experience for developers.

Since the global.json file requires the .NET 8 SDK, all the package references to Microsoft.SourceLink.GitHub could be removed instead of updated to version 8.0.0.

@HofmeisterAn
Copy link
Collaborator Author

Thanks for sharing. I will remove it in the next few days 🧹.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants