Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ArangoDB module #1058

Merged
merged 3 commits into from
Dec 2, 2023
Merged

feat: Add ArangoDB module #1058

merged 3 commits into from
Dec 2, 2023

Conversation

ShirAvneri
Copy link
Contributor

What does this PR do?

Adds an ArangoDB container to the list of supported Testcontainers.

Why is it important?

Provides an ArangoDB test container.

How to test this PR

Run Testcontainers.ArangoDb.Tests.

@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit f42f0c7
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/656b4338085173000815a030
😎 Deploy Preview https://deploy-preview-1058--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

HofmeisterAn
HofmeisterAn approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, LGTM! I'll take a look at the other PR tomorrow. I need to do a few other things beforehand.

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Dec 2, 2023
@HofmeisterAn HofmeisterAn merged commit e036266 into testcontainers:develop Dec 2, 2023
9 checks passed
@ShirAvneri ShirAvneri deleted the feature/arangodb_container branch December 2, 2023 15:24
@ShirAvneri
Copy link
Contributor Author

Thanks @HofmeisterAn!

@eddumelendez
Copy link
Member

Here you can see the preview in the Module Catalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HofmeisterAn HofmeisterAn HofmeisterAn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShirAvneri @eddumelendez @HofmeisterAn