You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created unit tests that test against the four tagged versions 2.5-ss, 2.5-sc, 3.0, 4.0
This is because the 2.5 versions behave differently and as such I wanted to ensure all the currently available versions will work.
Comment
The code is based on the implementation of the MsSql project and the mentioned firebird-testcontainers-java repository. I am open to discuss if this is the right place or rather the firebird repository.
Thank you for addressing the comments. I have made some minor changes to ensure the module aligns with the other modules. I left three additional comments, and happy to merge the PR soon, once those comments are addressed. Thank you again.
Thank you for addressing the comments. I have made some minor changes to ensure the module aligns with the other modules. I left three additional comments, and happy to merge the PR soon, once those comments are addressed. Thank you again.
Thank you for your commits. I ran into an issue where the path to the database does not need to be modified with the /firebird/data path when using EntityFramework instead of the raw SqlConnection. I am still trying to figure out why that is. Until I can figure that out we should leave the PR open, it seems I prematurely opened it.
I may ask/involve someone from firebird on that topic and see what is up with the different ways the provider behaves.
Thank you for addressing the comments. I have made some minor changes to ensure the module aligns with the other modules. I left three additional comments, and happy to merge the PR soon, once those comments are addressed. Thank you again.
Thank you for your commits. I ran into an issue where the path to the database does not need to be modified with the /firebird/data path when using EntityFramework instead of the raw SqlConnection. I am still trying to figure out why that is. Until I can figure that out we should leave the PR open, it seems I prematurely opened it. I may ask/involve someone from firebird on that topic and see what is up with the different ways the provider behaves.
If we figure out the correct wait strategy, I think we can merge the PR in the meantime (if you like). We can then update the configuration to work with EF afterward.
Thank you for addressing the comments. I have made some minor changes to ensure the module aligns with the other modules. I left three additional comments, and happy to merge the PR soon, once those comments are addressed. Thank you again.
Thank you for your commits. I ran into an issue where the path to the database does not need to be modified with the /firebird/data path when using EntityFramework instead of the raw SqlConnection. I am still trying to figure out why that is. Until I can figure that out we should leave the PR open, it seems I prematurely opened it. I may ask/involve someone from firebird on that topic and see what is up with the different ways the provider behaves.
If we figure out the correct wait strategy, I think we can merge the PR in the meantime (if you like). We can then update the configuration to work with EF afterward.
That sounds good, I will take a look at open comments and issues (next week) and we can incrementally improve this.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding Testcontainers.FirebirdSql project that allows to use Firebird SQL with Testcontainers
Why is it important?
Firebird SQL is not supported for Testcontainers .NET yet.
There is support for Testcontainers Java on the Firebird Repository (https://github.com/FirebirdSQL/firebird-testcontainers-java) which these changes are based on.
Related issues
none
How to test this PR
I created unit tests that test against the four tagged versions 2.5-ss, 2.5-sc, 3.0, 4.0
This is because the 2.5 versions behave differently and as such I wanted to ensure all the currently available versions will work.
Comment
The code is based on the implementation of the MsSql project and the mentioned firebird-testcontainers-java repository. I am open to discuss if this is the right place or rather the firebird repository.