feat: Add Milvus module #1131
feat: Add Milvus module #1131
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Thanks for the PR. The module configurations look good 👍. Do you mind if I update some parts to align the module with all the others? Usually, this helps me to refactor stuff that involves changes in the modules too. Either way, I am happy to merge the PR afterwards.
|
Thanks for merging @HofmeisterAn! Looking forward to seeing this on nuget.org! |
|
@HofmeisterAn let me know if I can give a hand in updating the docs, or any other task needed to getting this published/doc'ed etc. |
|
The module is published together with a new Testcontainers version/release. If you like, I can create a pull request and add the .NET implementation to the modules catalog after the release. |
|
That would be great, thanks! |
The qdrant gRPC client uses .NET Framework build of Grpc.Net.Client, which uses WinHttpHandler. The wiring up is easier on net462 if net462 is targeted specifically. Same reason why the Milvus container also targets net462 (testcontainers#1131 (comment)).
This adds a test container for the Milvus vector database.
This largely follows the existing Milvus Java testcontainer; potentially more configuration knobs could be exposed, but we can do that if/when users request them.
Let me know about any adjustments you'd like made!
/cc @yhmo @weianweigan