feat: Use built-in PEM certificate import on .NET 6 and onwards #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to drop the BouncyCastle.Cryptography dependency (almost 7 MB) when targeting net6.0 and net8.0. Additionnally, the `Microsoft.Bcl.AsyncInterfaces` and `System.Text.Json` dependencies are also dropped when targeting .NET 6 and later.
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…iners-dotnet into 0xced-Conditional-BouncyCastle
HofmeisterAn
changed the title
HofmeisterAn
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull requests uses the built-in PEM certificate import on .NET 6 onwards and updates the package references conditionally on the target framework.
BouncyCastle.Cryptography,Microsoft.Bcl.AsyncInterfacesandSystem.Text.Jsonare now referenced only when targeting .NET Standard (2.0 and 2.1) since they are not needed anymore when targeting .NET 6 onwards.Why is it important?
This allows to drop the BouncyCastle.Cryptography dependency (almost 7 MB) when targeting net6.0 and net8.0.
Related issues
None, I just saw that .NET 6 and .NET 8 support was added recently and took the opportunity to reduce the dependencies.
How to test this PR
Just run the existing tests and verify that nothing is broken. Note that some care had to be taken on Windows.