Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerImageOperations.BuildAsync - Throwing meaningful exception if docker image name is not lower case #512

Conversation

michal-korniak
Copy link

Currently this scenario isn't properly handled which leads to the exception with low level message that doesn't give any clues what went wrong.

image

I wanted to add unit tests to this, but it will require more time than I can afford, The BuildAsync method invokes methods from static classes, so it will be necessary to create additional abstractions to make it mockable.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add that as a guard methode to:

? Then it's easier to test too. What do think?

@michal-korniak
Copy link
Author

Much easier :) I moved the logic to the class you mentioned and I added some tests to check if it work properly.

@HofmeisterAn
Copy link
Collaborator

easier to test too. What do th

Cool, thanks. I'll do the review and merge later that day 👏.

@HofmeisterAn
Copy link
Collaborator

I fixed the unit test, thanks (dcd1858).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants