add method to set a fixed container mac address #616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method WithMacAddress to set a fixed mac address to a container in TestContainersBuilder. As background information: I want to test software that requires a license key that is tied to the mac address.
HofmeisterAn
requested changes
Oct 15, 2022
src/Testcontainers/Configurations/Containers/ITestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/Containers/TestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/Containers/TestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/Containers/TestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/Containers/TestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
…nfiguration.cs fix typo Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
…figuration.cs rename macaddress to macAddress Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
…figuration.cs rename macaddress to macAddress Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
…figuration.cs add inherit doc Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
…figuration.cs rename macaddress to macAddress Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
add test for the feature to set a fixed mac address for a container
|
Thanks for the quick review! I executed the suggested renaming and added a test. Viele Grüße aus dem Schwarzwald. ;) |
HofmeisterAn
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method 'WithMacAddress' to set a fixed mac address to a container in TestContainersBuilder. As background information to why I need this: I want to test software that requires a license key that is tied to the mac address.