Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitHub Codespaces configuration (Dev Container) #735

Merged
merged 18 commits into from
Jan 17, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

This PR contains three major changes. It updates the NuGet dependencies (1) and removes the global output directory (2). Unfortunately, the latest versions of the .NET SDK break more and more things in regards of the global output directory. Considering the GitHub issues it does not look like MS will add the compatibility again (it has worked since the .NET Framework).

Furthermore, it adds a Dev Container configuration to use Testcontainers with GitHub Codespaces (3)

Why is it important?

Simplifies the .NET build and adds GitHub Codespaces support.

Related issues

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Jan 16, 2023
@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 341753d
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63c5bef25cd0cd000854cdd0
😎 Deploy Preview https://deploy-preview-735--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kiview
kiview previously approved these changes Jan 16, 2023
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably start like this, but I would suggest exploring Devcontainers Features to make the config a bit simpler (e.g. regarding Docker):
https://code.visualstudio.com/blogs/2022/09/15/dev-container-features

Can be done as a follow-up, to just start from a working state, so in favor of merging like this 👍

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@eddumelendez
Copy link
Member

Looks like dotnet can be also added as a feature "ghcr.io/devcontainers/features/dotnet:1": {}

Copy link
Collaborator Author

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I replaced the Dockerfile with the Dev Container features.

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@HofmeisterAn HofmeisterAn changed the title Feature/add dev container feat: Add GitHub Codespaces configuration (Dev Container) Jan 17, 2023
@HofmeisterAn HofmeisterAn merged commit 9614bb7 into develop Jan 17, 2023
@HofmeisterAn HofmeisterAn deleted the feature/add-dev-container branch January 17, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants