Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wait until LocalStack writes ready message #738

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

Changes the LocalStack readiness check to wait until the container writes the ready message.

Why is it important?

Previous readiness check did not always complete.

Related issues

-

@HofmeisterAn HofmeisterAn added the bug Something isn't working label Jan 17, 2023
@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit ea64bbf
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63c68caa4d29a0000823ee00
😎 Deploy Preview https://deploy-preview-738--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn merged commit b7a8a32 into develop Jan 17, 2023
@HofmeisterAn HofmeisterAn deleted the bugfix/change-localstack-wait-strategy branch January 17, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant