Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DynamoDB module #768

Merged
merged 21 commits into from
Feb 10, 2023

Conversation

dominikus1993
Copy link
Contributor

What does this PR do?

Add support for amazon DynamoDB testcontainer module.

Why is it important?

I think that adding this testcontainer will be useful for developers who want to test the operation of aws dynamodb

Related issues

  • Any of issues are no releated

How to test this PR

Running the new integration test will suffice.

@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit a25a402
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63e60a7086a3c000081d5eaf
😎 Deploy Preview https://deploy-preview-768--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your contribution again. I have a few suggestions for improvements.

src/Testcontainers.DynamoDB/DynamoDBBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.DynamoDB/DynamoDBBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.DynamoDB/DynamoDBBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.DynamoDB/DynamoDBContainer.cs Outdated Show resolved Hide resolved
src/Testcontainers.DynamoDB/DynamoDBContainer.cs Outdated Show resolved Hide resolved
src/Testcontainers.DynamoDB/Testcontainers.DynamoDB.csproj Outdated Show resolved Hide resolved
src/Testcontainers.DynamoDB/Usings.cs Outdated Show resolved Hide resolved
tests/Testcontainers.DynamoDB.Tests/Usings.cs Outdated Show resolved Hide resolved
@HofmeisterAn HofmeisterAn changed the title Add Aws DynamoDB Module feat: Add DynamoDB module Feb 10, 2023
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Feb 10, 2023
@HofmeisterAn HofmeisterAn merged commit 06bb7e0 into testcontainers:develop Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants