Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InvalidOperationException when adding future volume #817

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

Defers the resolution of the future volume name to a later point.

Why is it important?

Accessing the property (name) immediately will raise InvalidOperationException. Depending on when the developer passes the instance to VolumeMount (the builder) it may not, nor is it necessary to exist yet.

Related issues

@HofmeisterAn HofmeisterAn added the bug Something isn't working label Mar 3, 2023
@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 65ac053
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6401d23456e13f00088a9bcd
😎 Deploy Preview https://deploy-preview-817--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn merged commit 87b7505 into develop Mar 3, 2023
@HofmeisterAn HofmeisterAn deleted the bugfix/invalidoperationexception-when-adding-future-volume branch March 3, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: InvalidOperationException when adding future volume
1 participant