Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add K3s module #835

Merged
merged 5 commits into from
Mar 22, 2023

Conversation

adar2
Copy link
Contributor

@adar2 adar2 commented Mar 15, 2023

What does this PR do?

Introduce K3s Module.

Why is it important?

Allows testing k8s integration without using a real cluster.

@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 272afe8
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/641990900db78e0007969ae5
😎 Deploy Preview https://deploy-preview-835--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@adar2 adar2 changed the title added k3s container Introduce K3s Module Mar 17, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request! Most parts look good, although I have a few change requests in regards of Testcontainers best practices. Happy to merge the PR soon as they are addressed 🙏.

src/Testcontainers.K3s/K3sBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.K3s/K3sBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.K3s/K3sContainer.cs Outdated Show resolved Hide resolved
adar2 and others added 2 commits March 20, 2023 16:17
removed custom wait strategy.
removed KubeConfigYaml property.
introduced GetKubeConfig method.
@HofmeisterAn HofmeisterAn changed the title Introduce K3s Module feat: Add K3s module Mar 22, 2023
@HofmeisterAn HofmeisterAn merged commit 710987a into testcontainers:develop Mar 22, 2023
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants