feat: Always use Docker's assigned random host port (Ryuk) #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned random host port
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
HofmeisterAn
commented
Mar 27, 2023
HofmeisterAn
commented
Mar 28, 2023
kiview
previously approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extends the .NET documentation and explains that the Docker Wormhole configurations should use Docker's raw socket due to a bug in Docker Desktop. Furthermore, it sets the
ResourceReaperPublicHostPortdelegate obsolete. The Resource Reaper no longer uses the API to configure the assigned host port.Why is it important?
The PR provides more information about the Docker Wormhole configuration and use the same port assignment everywhere. The Resource Reaper was the only exception that uses the
0assignments instead ofstring.Empty.Related issues