Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor legacy TestcontainersContainerTest class #901

Merged
merged 1 commit into from
May 24, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

The pull request slightly adjusts the legacy Testcontainers for .NET tests to support the container runtime environment Podman. Rootless Podman cannot expose privileged ports.

Why is it important?

To integrate Podman into our CI pipeline, it is necessary to fix the failing tests first.

Related issues

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label May 24, 2023
@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit b6e6516
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/646dbf817f448e000848cdf3
😎 Deploy Preview https://deploy-preview-901--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn merged commit eedd883 into develop May 24, 2023
13 checks passed
@HofmeisterAn HofmeisterAn deleted the bugfix/refactor-legacy-test-to-support-podman branch May 24, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant