feat: Add UsingHttpMessageHandler(HttpMessageHandler) to HttpWaitStrategy #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
HofmeisterAn
reviewed
Jun 2, 2023
src/Testcontainers/Configurations/WaitStrategies/HttpWaitStrategy.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/WaitStrategies/HttpWaitStrategy.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
HofmeisterAn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the ability to pass a custom HttpClientHandler to the HttpWaitStrategy.
Why is it important?
One reason for passing a custom HttpClientHandler would be the ability to tell the health checks to ignore or deviate from local proxy settings (often useful if tests are being executed on a build agent which sits behind a proxy, where the settings for that proxy get in the way of communicating with the container).