Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure site_url is set in the MkDocs config to prevent <loc>None</loc> in sitemap generation #927

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

leocross
Copy link
Contributor

What does this do

Fix a bug with the documentation generating a sitemap with <loc>None</loc> seamingly caused by not having site_url set in the mkdocs config.

e.g.

<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
  <url>
    <loc>None</loc>
    <lastmod>2023-06-15</lastmod>
    <changefreq>daily</changefreq>
  </url>
  ...
</urlset>

Why this is important

Search engines and other tools use the sitemap. Presenting correct information is important for discoverability of the documentation.

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit be236ef
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6491e3a2245c8800085c99d8
😎 Deploy Preview https://deploy-preview-927--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn changed the title Fix locations set to None in sitemap fix: Ensure site_url is set in the MkDocs config to prevent <loc>None</loc> in sitemap generation Jun 21, 2023
@HofmeisterAn HofmeisterAn added the bug Something isn't working label Jun 21, 2023
@HofmeisterAn HofmeisterAn merged commit f867967 into testcontainers:develop Jun 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants