Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve error message when Docker is not running #987

Merged

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Aug 31, 2023

Before this commit, the error message implied that there was a configuration error while it could simply be that Docker was not running.

Before this commit, the error message implied that there was a configuration error while it could simply be that Docker was not running.
@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 77063c3
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64f205fa523b1b00071a04fd
😎 Deploy Preview https://deploy-preview-987--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Sep 1, 2023
@HofmeisterAn HofmeisterAn changed the title Improve the error message when Docker is not running chore: Improve error message when Docker is not running Sep 1, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@HofmeisterAn HofmeisterAn merged commit 604ae2c into testcontainers:develop Sep 1, 2023
10 checks passed
@0xced 0xced deleted the ImprovedConfigurationErrorMessage branch September 1, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants