Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send user_agent in connection constructor #95

Merged
merged 1 commit into from
May 15, 2024

Conversation

jarlah
Copy link
Collaborator

@jarlah jarlah commented May 15, 2024

fixes #94

@@ -29,8 +26,7 @@ defmodule Testcontainers.Docker.Api do

case Api.Image.image_create(conn,
fromImage: image,
"X-Registry-Auth": auth,
"User-Agent": Constants.user_agent()
"X-Registry-Auth": auth
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that this is indeed handled specifically in image_create

@jarlah jarlah merged commit a4e48a5 into main May 15, 2024
6 checks passed
@jarlah jarlah deleted the use_user_agent_in_connection_constructor branch May 15, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix User-Agent logic
1 participant