update PortBinding logic

testcontainers · May 18, 2023 · 959635c · 959635c
1 parent 59eca37
commit 959635c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lifecycle.go b/lifecycle.go
@@ -320,7 +320,13 @@ func (p *DockerProvider) preCreateContainerHook(ctx context.Context, req Contain
 	}
 
 	dockerInput.ExposedPorts = exposedPortSet
-	hostConfig.PortBindings = mergePortBindings(hostConfig.PortBindings, exposedPortMap, req.ExposedPorts)
+
+	// only exposing those ports automatically if the container request exposes zero ports and the container does not run in a container network
+	if len(exposedPorts) == 0 && !hostConfig.NetworkMode.IsContainer() {
+		hostConfig.PortBindings = exposedPortMap
+	} else {
+		hostConfig.PortBindings = mergePortBindings(hostConfig.PortBindings, exposedPortMap, req.ExposedPorts)
+	}
 
 	return nil
 }