gha: update golangci-lint to v1.59.1 (#2588)

* fix linting errors: negative-positive: use assert.Positive (testifylint)

Fix some linting issues that are produced when running a newer version
of testifylint;

    Error: negative-positive: use assert.Positive (testifylint)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* gha: update golangci-lint to v1.59.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* chore: bump version in Make too

---------

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>

.github/workflows/ci-test-go.yml

@@ -76,7 +76,7 @@ jobs:
         uses: golangci/golangci-lint-action@9d1e0624a798bb64f6c3cea93db47765312263dc # v5
         with:
           # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: v1.55.2
+          version: v1.59.1
           # Optional: working directory, useful for monorepos
           working-directory: ${{ inputs.project-directory }}
           # Optional: golangci-lint command line arguments.

commons-test.mk

@@ -6,7 +6,7 @@ define go_install
 endef
 
 $(GOBIN)/golangci-lint:
-	$(call go_install,github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.2)
+	$(call go_install,github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59.1)
 
 $(GOBIN)/gotestsum:
 	$(call go_install,gotest.tools/gotestsum@latest)

docker_test.go

@@ -2176,7 +2176,7 @@ func TestDockerProvider_BuildImage_Retries(t *testing.T) {
 			defer cancel()
 			_, _ = p.BuildImage(ctx, &ContainerRequest{})
 
-			assert.Greater(t, m.imageBuildCount, 0)
+			assert.Positive(t, m.imageBuildCount)
 			assert.Equal(t, tt.shouldRetry, m.imageBuildCount > 1)
 		})
 	}
@@ -2227,7 +2227,7 @@ func TestDockerProvider_waitContainerCreation_retries(t *testing.T) {
 			defer cancel()
 			_, _ = p.waitContainerCreation(ctx, "someID")
 
-			assert.Greater(t, m.containerListCount, 0)
+			assert.Positive(t, m.containerListCount)
 			assert.Equal(t, tt.shouldRetry, m.containerListCount > 1)
 		})
 	}
@@ -2288,7 +2288,7 @@ func TestDockerProvider_attemptToPullImage_retries(t *testing.T) {
 			defer cancel()
 			_ = p.attemptToPullImage(ctx, "someTag", image.PullOptions{})
 
-			assert.Greater(t, m.imagePullCount, 0)
+			assert.Positive(t, m.imagePullCount)
 			assert.Equal(t, tt.shouldRetry, m.imagePullCount > 1)
 		})
 	}