Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run jobs if and only if the upstream workflow completed with success #1133

Closed

Conversation

mdelapenya
Copy link
Collaborator

  • chore: run workflow if and only if the upstream workflow_run completed with success
  • fix: rename job for modulegen pipeline

What does this PR do?

It adds an IF condition on each job so that the upstream workflow needs to complete with success in order to trigger the current workflow.

Why is it important?

A workflow run is triggered regardless of the conclusion of the previous workflow

See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-a-workflow-based-on-the-conclusion-of-another-workflow

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner May 4, 2023 05:51
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label May 4, 2023
@mdelapenya mdelapenya self-assigned this May 4, 2023
@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit d74e1af
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6453957ffbd126000879fcee
😎 Deploy Preview https://deploy-preview-1133--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya
Copy link
Collaborator Author

Superseded by #1414

@mdelapenya mdelapenya closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant