Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modulegen: generate sonar configuration #1644

Merged
merged 1 commit into from
Sep 19, 2023
Merged

modulegen: generate sonar configuration #1644

merged 1 commit into from
Sep 19, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Sep 18, 2023

What does this PR do?

Generate sonar.go.tests.reportPaths in sonar-project.properties

Why is it important?

sonar.go.tests.reportPaths doesn't supports wilcards so all the paths needs to be listed to avoid seeing this :

INFO: Sensor Go Unit Test Report [go]
ERROR: Test report can't be loaded, file not found: '/github/workspace/**/TEST-unit.xml', ignoring this file.

@mmorel-35 mmorel-35 requested a review from a team as a code owner September 18, 2023 20:04
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit b9a1f63
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6508b14bafe91a000853ef8c
😎 Deploy Preview https://deploy-preview-1644--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mdelapenya mdelapenya self-assigned this Sep 19, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Sep 19, 2023
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

At the same time it's weird that sonarqube does not accept glob expressions in the test reports path 🤷

@mdelapenya mdelapenya merged commit e9fba55 into testcontainers:main Sep 19, 2023
104 checks passed
@mmorel-35 mmorel-35 deleted the sonarcloud branch September 19, 2023 07:45
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 20, 2023
* main:
  fix: proper next version
  chore: prepare for next minor development cycle ()
  chore: use new version (v0.24.0) in modules and examples
  fix: include sonarcloud file into the release commit
  modulegen: generate sonar configuration (testcontainers#1644)
  feat: define test session semantics (testcontainers#1513)
  chore(deps): bump actions/checkout from 3 to 4 (testcontainers#1623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants