Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default timeout in SQL waiter #196

Merged
merged 2 commits into from
May 15, 2020
Merged

Use default timeout in SQL waiter #196

merged 2 commits into from
May 15, 2020

Conversation

mniak
Copy link
Contributor

@mniak mniak commented May 14, 2020

Closes #193

mdelapenya
mdelapenya approved these changes May 14, 2020
View reviewed changes
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gianarb gianarb added the breaking change Causing compatibility issues. label May 15, 2020
@gianarb
Copy link
Collaborator

gianarb commented May 15, 2020

I added bc-break only because it changes the behavior of the function for end user.

Thanks

@gianarb gianarb merged commit df1a688 into testcontainers:master May 15, 2020
@mniak mniak deleted the sql_to branch May 15, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees
No one assigned
Labels
breaking change Causing compatibility issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sql wait strategy does not use defaultStartupTimeout
3 participants
@mniak @gianarb @mdelapenya