Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll interval #200

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Poll interval #200

merged 4 commits into from
Sep 18, 2020

Conversation

mniak
Copy link
Contributor

@mniak mniak commented May 21, 2020

Closes #197

mdelapenya
mdelapenya reviewed May 21, 2020
View reviewed changes
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you add a few tests for the new behavior, also updating existing examples?

Thanks!

@mniak
Copy link
Contributor Author

mniak commented Aug 6, 2020

Hi, @mdelapenya, I created tests checking the behavior of the constructors.

@mniak
Copy link
Contributor Author

mniak commented Aug 6, 2020

I also moved the example to a folder example in order to avoid conflicts

mdelapenya
mdelapenya approved these changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on PTO today, and reviewed on there phone, but LGTM

Thanks for your efforts with the tests ☺️

@mniak mniak mentioned this pull request Aug 12, 2020
Closed
@gianarb
Copy link
Collaborator

gianarb commented Sep 18, 2020

Hello @mniak

Sorry, I am really late for this! Do you mind rebasing?

@mniak
Copy link
Contributor Author

mniak commented Sep 18, 2020

@gianarb synced.
Additionally, I introduced a function defaultPollInterval() in order to "standardize" the default poll interval.

@gianarb gianarb merged commit 9d93888 into testcontainers:master Sep 18, 2020
@gianarb
Copy link
Collaborator

gianarb commented Sep 18, 2020 •
edited
Loading

Great thanks a lot! And sorry it took me so long!

This was referenced Mar 15, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PollInterval to the waiters for sql, http and host_port
3 participants
@mniak @gianarb @mdelapenya