-
-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding surrealDB module #2192
Adding surrealDB module #2192
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Same as #2244 (comment). Would you evaluate to host the module? As described in the docs, if you don't feel can do it, it's fine having it here |
@mdelapenya for this specific one I prefer it to go here. |
I think the lint is complaining on the module https://github.com/testcontainers/testcontainers-go/actions/runs/8018977780/job/21906230055?pr=2192 Could you run |
@mdelapenya done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jespino looks good to me having the module here, let's address the comments and we are to go. Thank you for your time 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It LGTM although I added a few comments 🙏
Thanks!
* main: chore: bump Go version to 1.21 (testcontainers#2292) chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (testcontainers#2226) feat: WithLogger ContainerCustomizer support (testcontainers#2259) chore(deps): bump github.com/jackc/pgx/v5 in /modules/cockroachdb (testcontainers#2217) Move the file and mounts tests into a test package (testcontainers#2270) Fix Dockerfile not located when added to dockerignore (testcontainers#2272)
@jespino I added the docs for the module, thanks! Please take a look before merging if possible 🙏 |
@mdelapenya sorry about the delay, I've been pretty busy lately. I added a couple of comments (one of them you already fixed it). Otherwise, it looks good to me. Thanks! |
@jespino I'm merging this one. Thank you so much for your contributions, they are adding lots of value to the project!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* main: chore(deps): bump github.com/docker/docker from 25.0.2+incompatible to 25.0.3+incompatible (testcontainers#2296) chore(deps): bump github.com/couchbase/gocb/v2 from 2.7.1 to 2.7.2 in /modules/couchbase, github.com/tidwall/gjson from 1.17.0 to 1.17.1 in /modules/couchbase (testcontainers#2297) chore(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (testcontainers#2295) chore(deps): bump github.com/microsoft/go-mssqldb in /modules/mssql (testcontainers#2288) chore(deps): bump github.com/amikos-tech/chroma-go in /modules/chroma (testcontainers#2275) chore(deps): bump google.golang.org/grpc from 1.61.1 to 1.62.0 in /modules/gcloud, google.golang.org/api from 0.165.0 to 0.167.0 in /modules/gcloud, cloud.google.com/go/pubsub from 1.36.1 to 1.36.2 in /modules/gcloud (testcontainers#2293) chore(deps): bump github.com/nats-io/nats.go in /modules/nats (testcontainers#2253)
What does this PR do?
This PR adds the SurrealDB module. (This module is heavily inspired by the rust implementation)
Why is it important?
SurrealDB is a database system that is getting more a more popular lately, so it can help users to test it using testcontainers.
How to test this PR
This PR include unit tests for the module