Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated compose-go version #2340

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

shettyh
Copy link
Contributor

@shettyh shettyh commented Mar 11, 2024

What does this PR do?

Updated the docker compose version as with latest golang.org/x/exp package, test containers usage was breaking with error

# github.com/compose-spec/compose-go/v2/override
../../Go/pkg/mod/github.com/compose-spec/compose-go/v2@v2.0.0-rc.2/override/merge.go:165:24: type func(a any, b any) bool of func(a, b any) bool {…} does not match inferred type func(a any, b any) int for func(a E, b E) int
# github.com/fsnotify/fsevents

Why is it important?

Because it is breaking the builds after updating the golang.org/x/exp package

Related issues

@shettyh shettyh requested a review from a team as a code owner March 11, 2024 09:14
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit ca7c661
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65eecb7641aa3f0008c7bb0b
😎 Deploy Preview https://deploy-preview-2340--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya self-assigned this Mar 11, 2024
@mdelapenya mdelapenya added the dependencies Dependencies or external services label Mar 11, 2024
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for bumping the compose version! 🙇

@mdelapenya mdelapenya merged commit f81826b into testcontainers:main Mar 11, 2024
98 checks passed
mdelapenya added a commit to JJCinAZ/testcontainers-go that referenced this pull request Mar 13, 2024
* main: (239 commits)
  Move the container and config tests into a test package (testcontainers#2242)
  Added error handling for context.Canceled in log reading code (testcontainers#2268)
  chore: updated docker compose version (testcontainers#2340)
  Add method for getting Weaviate's gRPC port (testcontainers#2339)
  chore: use withEnv in localstack module (testcontainers#2337)
  docs: fix wrong copy&paste (testcontainers#2338)
  fix: consul race on HTTP port (testcontainers#2336)
  chore(deps): bump mkdocs-material from 8.2.7 to 9.5.13 (testcontainers#2334)
  feat: add openfga module (testcontainers#2332)
  chore: retire dependabot (testcontainers#2325)
  chore: check that the new version is not empty (testcontainers#2331)
  chore: prepare for next minor development cycle (0.30.0)
  chore: use new version (v0.29.1) in modules and examples
  fix: incorrect version
  chore: prepare for next minor development cycle ()
  chore: use new version (v0.29.0) in modules and examples
  generic.go: GenericContainer(): clearer error message (testcontainers#2327)
  chore: confirm support for new mongo images (testcontainers#2326)
  Add k3s WithManifest option (testcontainers#1920)
  chore(deps): bump google.golang.org/grpc in /modules/qdrant (testcontainers#2281)
  ...
@arctic-acadian
Copy link

arctic-acadian commented Mar 20, 2024

Wondering if this code deployed we're having trouble using it. Thank you for the changes @shettyh

/home/vscode/go/pkg/mod/github.com/testcontainers/testcontainers-go/modules/compose@v0.29.1/compose_api.go:343:38: not enough arguments in call to cli.ProjectFromOptions
	have (*"github.com/compose-spec/compose-go/v2/cli".ProjectOptions)
	want ("context".Context, *"github.com/compose-spec/compose-go/v2/cli".ProjectOptions) (exit status 1)

@podjay
Copy link

podjay commented Apr 2, 2024

Seconded on getting this fix released! 🤞🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants