Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logging deadlock #2346

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix: logging deadlock #2346

merged 2 commits into from
Apr 4, 2024

Commits on Apr 3, 2024

  1. fix: logging deadlock 

    Fix logging deadlock, causing lots of test timeouts.

This refactors how logging shutdown is handled, eliminating unnecessary
captures, use idiomatic wait group to signal processor completion and
remove unnecessary nil initialisation.

Fix race condition in log testing which was reading Msg while the
processor was still running.

Switch to checking GITHUB_RUN_ID environment variable to detect GitHub
as XDG_RUNTIME_DIR can be present in other situations.
    @stevenh
    stevenh committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    de3b969 View commit details
    Browse the repository at this point in the history

  2. fix: Docker container Terminate returning early 

    Fix Docker container Terminate returning early when context is
cancelled, which was leaving orphaned running containers.

This ensures that all life cycle hooks are run even if one errors
returning a multi error if needed.
    @stevenh
    stevenh committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    35cb59d View commit details
    Browse the repository at this point in the history