Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving issue #248 #249

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Resolving issue #248 #249

merged 2 commits into from
Sep 24, 2020

Conversation

ikolomiyets
Copy link
Contributor

The function CreateContainer has been refactored so when more than one network specified in the container request, only first one is used to call Docker's ContainerCreate function and upon successful creation of the container it is connected the remaining networks using Docker's NetworkConnect function.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution, it LGTM

@gianarb gianarb merged commit 96eac21 into testcontainers:master Sep 24, 2020
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants